Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward http port at application startup #857

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jan 23, 2023

Description

Http port are forwarded while starting ArchethicWeb.Supervisor in init function.
While performing a hot reload, the supervisor init function are called to update the supervisor child and strategy. But because of the http forwarding in init function that can take some times, the hot reload may fall in timeout.

To avoid this, the http port forwarding are moved to application start.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added the bug Something isn't working label Jan 23, 2023
@Neylix Neylix merged commit 8ed3ce7 into archethic-foundation:develop Jan 24, 2023
@Neylix Neylix deleted the move-http-port-forwarding branch January 24, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants